New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperate open/close port from subscription? #3

Open

DanielJoyce opened this issue May 11, 2017 · 0 comments

Collaborator

DanielJoyce commented May 11, 2017

Currently when you open a port opened by someone else, you are really subscribing to said port

When you close a port, the underlying serial port is not closed till all other clients close that port as well. Its more like unsubscription.

Should we seperate the two?

Client who opens port gets write-lock to port
Client which subscribes to port gets all read events
Client with writelock can close port
1. All other clients would be notified of closure
unsubscribe does not close port, leaves port open but releases write locks
other clients can then write lock port to get read/close control of it
client dropping off does not close port either

DanielJoyce mentioned this issue

Specify certain ports should be auto-opened by server when started? #4

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment