Allow setting the node runtime to use for the language server. Fixes #345 #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not really sure what the travis failures are all about, they seem unrelated to my changes :( |
|
@Mossop nice work. One minor request. Can we name the setting |
dbaeumer
reviewed
Aug 20, 2018
README.md
Outdated
| @@ -22,6 +22,7 @@ This extension contributes the following variables to the [settings](https://cod | |||
| ``` | |||
| - `eslint.run` - run the linter `onSave` or `onType`, default is `onType`. | |||
| - `eslint.autoFixOnSave` - enables auto fix on save. Please note auto fix on save is only available if VS Code's `files.autoSave` is either `off`, `onFocusChange` or `onWindowChange`. It will not work with `afterDelay`. | |||
| - `eslint.server.runtime` - use this setting to set the path of the node runtime to run ESLint under. | |||
There was a problem hiding this comment.
I suggest to name this eslint.runtime. eslint.nodePath is for the server as well and we never put server into the naming so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #345 it is useful toi be able to select the node version to run ESLint as. This adds the eslint.server.runtime setting which can be set to the path of the node binary to use.