Add support for Redstone 5 #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2019 22:21
|
Didn't see the tests, will implement that later |
|
cc @philliphoff |
| @@ -36,8 +36,10 @@ const DotNetCoreSdkImageFormat = "microsoft/dotnet:{0}.{1}-sdk{2}"; | |||
|
|
|||
| function GetWindowsImageTag(): string { | |||
| // The host OS version needs to match the version of .NET core images being created | |||
| if (!isWindows() || isWindows10RS4OrNewer()) { | |||
| if (!isWindows() || isWindows10RS5OrNewer()) { | |||
| // If we're not on Windows (and therefore can't detect the version), assume a Windows RS4 host | |||
|
Thanks, will await the tests. We have a release of the extension going out in a about a week. |
|
@StephenWeatherford Test now seems fine. Did I miss anything? |
StephenWeatherford
approved these changes
Feb 27, 2019
|
In Ulm, um Ulm, und um Ulm herum… :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Redstone 5 which should generate Dockerfiles referencing -1809 images
Fixes #805