-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libftdi-compat] Add new port #6843
Conversation
…OLS with a def file. Minimize patching.
Hi @seanyen, thanks for making this PR! I made quite a few changes:
I'm not sure whether there were breaking changes in 1.4 that prevented you from using it, or if it was just because you had trouble getting it to build on windows. If you need 0.20 specifically and we can't make 1.4 work, let me know and we'll figure out what the right way forward is. |
Thank @ras0219-msft for iterating my changes! I specifically made the JFYI, here are some naming examples from other systems for
Can we do the similar thing to keep two ports ( |
@ras0219-msft just a friendly reminder. Any suggestions to keep both versions? |
Thanks for the ping! As noted in the commit message, I decided to use One note is that these two DLLs have overlapping symbols, so they really shouldn't be installed side-by-side. Edit: Another note -- I replaced your FindXYZ-style integration script with a config-style integration script. This solves some issues with debug mode that your script had, however it does mean you need to use modern cmake (target-based) and link against |
libFTDI is an open source library to talk to FTDI chips. This port is for v0.20.