Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[byte-lite] Add new port (v0.2.0) #6630

Merged
merged 3 commits into from
May 31, 2019
Merged

[byte-lite] Add new port (v0.2.0) #6630

merged 3 commits into from
May 31, 2019

Conversation

martinmoene
Copy link
Contributor

@martinmoene martinmoene commented May 26, 2019 •
edited
Loading

See also issue #1489

Neumann-A
Neumann-A reviewed May 26, 2019
View reviewed changes
ports/byte-lite/portfile.cmake Outdated
SHA512 eefc730a39453dfc367a4478a84d4825cd85721d3c332a57321d0a5c3040a4d45921603ff24220f968dd21df61acea856ae30db8bae6c1e835a1755fb03c84b7
)

file(INSTALL ${SOURCE_PATH}/include/nonstd/byte.hpp DESTINATION ${CURRENT_PACKAGES_DIR}/include/nonstd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line and do a proper install.
missing vcpkg_configure_cmake, vcpkg_install_cmake and vcpkg_fixup_cmake_targets
your CMakeLists.txt looks like it should be done this way!

@ras0219-msft
Copy link
Contributor

Thanks for the PR!

We'd like to also have the cmake -config files installed, so could you use the helpers:

vcpkg_configure_cmake(SOURCE_PATH ${SOURCE_PATH} PREFER_NINJA)
vcpkg_install_cmake()
vcpkg_fixup_cmake(CONFIG_PATH lib/cmake/${PORT})

@martinmoene
Copy link
Contributor Author

martinmoene commented May 27, 2019 •
edited
Loading

@ras0219 Can you give a hint where ${PORT} is documented?

@grdowns
Copy link
Contributor

grdowns commented May 31, 2019

Thanks for all these port contributions, @martinmoene! Due to the number of contributions in such a short span I'll thank you here and just press the merge button for the other applicable ones. 🎉

@grdowns grdowns merged commit 2e5e481 into microsoft:master May 31, 2019
@martinmoene
Copy link
Contributor Author

Thanks @grdowns !
Five more PRs to follow ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

Assignees

@grdowns grdowns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinmoene @ras0219-msft @grdowns @Neumann-A