Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libogg] Update to 1.3.3-3 #6588

Merged
merged 3 commits into from
Jun 14, 2019
Merged

Conversation

evpobr
Copy link
Contributor

@evpobr evpobr commented May 24, 2019

  • No patches required (merged in upstream)

Notes:

Target name changed: Ogg::Ogg -> Ogg::ogg (official).

PS D:\vcpkg> vcpkg install libogg
The following packages will be built and installed:
    libogg[core]:x64-windows
Starting package 1/1: libogg:x64-windows
Building package libogg[core]:x64-windows...
-- Using cached D:/vcpkg/downloads/xiph-ogg-6ccfcc2dce48c0d430b45064d0e13c962a64c42f.tar.gz
-- Using source at D:/vcpkg/buildtrees/libogg/src/962a64c42f-3bdf14dc8f
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: D:/vcpkg/packages/libogg_x64-windows/share/libogg/copyright
-- Performing post-build validation
-- Performing post-build validation done
Building package libogg[core]:x64-windows... done
Installing package libogg[core]:x64-windows...
Installing package libogg[core]:x64-windows... done
Elapsed time for package libogg:x64-windows: 22.23 s

Total elapsed time: 22.23 s

The package libogg:x64-windows provides CMake targets:

    find_package(ogg CONFIG REQUIRED)
    target_link_libraries(main PRIVATE Ogg::ogg)

* No patches required (merged in upstream)

Notes:

Target name changed: Ogg::Ogg -> Ogg::ogg (official).
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

@Rastaban We should consider adding a wrapper that aliases the old name to the new name

@Rastaban
Copy link
Contributor

Rastaban commented Jun 5, 2019

/azp run

@Rastaban
Copy link
Contributor

Rastaban commented Jun 6, 2019

Failing on Mac/Linux due to case sensitive file system. The call to vcpkg_fixup_cmake_targets needs updated

CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:45 (message):
  
  '/Users/vagrant/azure_agent/_work/3/s/packages/libogg_x64-osx/debug/lib/cmake/Ogg'
  does not exist.
Call Stack (most recent call first):
  ports/libogg/portfile.cmake:19 (vcpkg_fixup_cmake_targets)
  scripts/ports.cmake:71 (include)

@Rastaban
Copy link
Contributor

This looks good, the only failure is a known 'flaky' port (which has already been addressed in the latest master) and is unrelated to this PR.

@Rastaban Rastaban merged commit 0ad6aae into microsoft:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants