Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 integrate prettier and eslint #1240

Merged
merged 43 commits into from
Jan 17, 2019
Merged

💅 integrate prettier and eslint #1240

merged 43 commits into from
Jan 17, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 17, 2019

closes #1235

"parser": "typescript",
"trailingComma": "es5",
"singleQuote": true
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can debate here on the prettier formatting options. https://prettier.io/docs/en/options.html

"prettier --write",
"git add"
]
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can potentially expand this to other file types, including markdown and css

@cwhitten
Copy link
Member

For any observers wondering why eslint instead of tslint, see this issue on the TypeScript project

@coveralls
Copy link

coveralls commented Jan 17, 2019

Pull Request Test Coverage Report for Build 1844

  • 1020 of 1361 (74.94%) changed or added relevant lines in 203 files are covered.
  • 236 unchanged lines in 48 files lost coverage.
  • Overall coverage increased (+0.2%) to 61.998%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/commands/botCommands.ts 24 25 96.0%
packages/app/client/src/commands/notificationCommands.ts 0 1 0.0%
packages/app/client/src/data/chatHelpers.ts 0 1 0.0%
packages/app/client/src/data/editorHelpers.ts 3 4 75.0%
packages/app/client/src/data/reducer/progressIndicator.ts 0 1 0.0%
packages/app/client/src/data/sagas/resourcesSagas.ts 4 5 80.0%
packages/app/client/src/ui/debug/storeVisualizer.tsx 2 3 66.67%
packages/app/client/src/ui/dialogs/azureLoginFailedDialog/azureLoginFailedDialogContainer.ts 1 2 50.0%
packages/app/client/src/ui/dialogs/azureLoginPromptDialog/azureLoginPromptDialogContainer.ts 1 2 50.0%
packages/app/client/src/ui/dialogs/azureLoginSuccessDialog/azureLoginSuccessDialogContainer.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
packages/app/client/src/data/action/explorerActions.ts 1 66.67%
packages/emulator/core/src/utils/createResponse/error.ts 1 0.0%
packages/app/client/src/data/sagas/resourcesSagas.ts 1 86.27%
packages/emulator/core/lib/directLine/middleware/startConversation.js 1 17.78%
packages/sdk/main/built/index.js 1 78.95%
packages/sdk/main/built/ipc/index.js 1 78.95%
packages/app/main/src/utils/writeFile.ts 1 12.5%
packages/emulator/core/lib/conversations/middleware/createConversation.js 1 19.23%
packages/app/client/src/data/action/connectedServiceActions.ts 1 91.67%
packages/app/client/src/commands/notificationCommands.ts 1 0.0%
Totals Coverage Status
Change from base Build 1838: 0.2%
Covered Lines: 5517
Relevant Lines: 7983

💛 - Coveralls

Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looking forward to giving this a whirl!

@a-b-r-o-w-n
Copy link
Contributor Author

@tonyanziano and I both did a regression pass which uncovered two unrelated issues (related to #1219 ). Merging this and will file new issues against the regressions.

@a-b-r-o-w-n a-b-r-o-w-n merged commit d71c03c into master Jan 17, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the prettier branch January 17, 2019 22:10
Copy link

@ZYBRAXIS ZYBRAXIS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<DeploymentConfiguration PackageId=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to prettier & eslint
5 participants