don't rely on NIX_PATH
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Aug 12, 2023
nixpkgs_review/builddir.py
Outdated
| @@ -63,7 +63,7 @@ def __init__(self, name: str) -> None: | |||
| os.environ["NIX_PATH"] = self.nixpkgs_path() | |||
|
|
|||
| def nixpkgs_path(self) -> str: | |||
| return f"nixpkgs={self.worktree_dir}:nixpkgs-overlays={self.overlay.path}" | |||
| return f"nixpkgs={self.worktree_dir} nixpkgs-overlays={self.overlay.path}" | |||
There was a problem hiding this comment.
Is space an allowed separator in the environment variable as well?
There was a problem hiding this comment.
reading the source code, I don't think it is
There was a problem hiding this comment.
I rewrote the patch to make nixpkgs-review not rely on NIX_PATH, hopefully I didn't accidently break something
There was a problem hiding this comment.
I actually find it quite handy to have a NIX_PATH set. Can we not just keep it, but not rely on it for our own tooling?
Nix does not respect `NIX_PATH` when the `nix-path` setting in nix.conf is set, which breaks the `nix-store --verify-path` due to `<nixpkgs>` diverging from the temporary nixpkgs created by nixpkgs-review.
Mic92
reviewed
Aug 12, 2023
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at e92c011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nix does not respect
NIX_PATHwhen thenix-pathsetting in nix.confis set, which breaks the
nix-store --verify-pathdue to<nixpkgs>diverging from the temporary nixpkgs created by nixpkgs-review.
fixes #343