Support extendModules for injecting nixos-shell's options and config modules
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if `extendModules` is available on the supplied NixOS configuration, in preference to using `override`. This permits callers to omit `makeOverridable` when using a recent-enough nixpkgs.
that describes the issue (inability to mix in nixos-shell's modules) and links to the README
namely a config that lacks both the `override` and `extendModules` attributes.
|
This |
|
Thanks for testing |
|
Configuration problem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset makes it possible for folks on a recent-enough
nixpkgsto usenixos-shellwithout declaring their system configs withlib.makeOverridable. Basically, thisnixos-generatorsPR, except:nixpkgsprior to the commit that introducedextendModules, andoverrideandextendModulesattributes.Thank you for your consideration.