addressing review comments

app/scripts/controllers/metametrics-data-deletion/metametrics-data-deletion.ts

@@ -2,21 +2,13 @@ import {
   BaseController,
   RestrictedControllerMessenger,
 } from '@metamask/base-controller';
+import { PublicInterface } from '@metamask/utils';
 import type { DataDeletionService } from '../../services/data-deletion-service';
 import { DeleteRegulationStatus } from '../../../../shared/constants/metametrics';
 
 // Unique name for the controller
 const controllerName = 'MetaMetricsDataDeletionController';
 
-/**
- * Get a type representing the public interface of the given type. The
- * returned type will have all public properties, but will omit private
- * properties.
- *
- * @template Interface - The interface to return a public representation of.
- */
-type PublicInterface<Interface> = Pick<Interface, keyof Interface>;
-
 /**
  * Timestamp at which regulation response is returned.
  */

shared/constants/metametrics.ts

@@ -855,12 +855,12 @@ export enum MetaMetricsContextProp {
  * Mentioned here: https://docs.segmentapis.com/tag/Deletion-and-Suppression#operation/listRegulationsFromSource
  */
 export enum DeleteRegulationStatus {
-  failed = 'FAILED',
-  finished = 'FINISHED',
-  initialized = 'INITIALIZED',
-  invalid = 'INVALID',
-  notSupported = 'NOT_SUPPORTED',
-  partialSuccess = 'PARTIAL_SUCCESS',
-  running = 'RUNNING',
-  unknown = 'UNKNOWN',
+  Failed = 'FAILED',
+  Finished = 'FINISHED',
+  Initialized = 'INITIALIZED',
+  Invalid = 'INVALID',
+  NotSupported = 'NOT_SUPPORTED',
+  PartialSuccess = 'PARTIAL_SUCCESS',
+  Running = 'RUNNING',
+  Unknown = 'UNKNOWN',
 }