Fix reprojection when datum transformations are set in project #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will need to do qgis-sdk update anyways, can you create QGIS PR, i would not put this workaround here... |
|
@wonder-sk are you sure this is required, the context is automatically set when you call QgsQuickMapSettings::setProject, see https://github.com/qgis/QGIS/blob/e7e08fd5045b4fbbec5078ed30de644dabd5ce41/src/quickgui/qgsquickmapsettings.cpp#L55 |
|
Yes, it is needed and it fixes a bug that was reported to me. Probably the QgsQuickMapSettings::setProject() is called on app startup with QgsProject::instance() when project is still empty, and then never called again (because we use the singleton) |
|
QGIS PR: qgis/QGIS#39010 |
Input was ignoring custom datum transformations set in QGIS projects which may have been causing subtle shifts in on-the-fly reprojection when the default coordinate operation was different from the preferred one.
PeterPetrik
force-pushed
the
fix-coordinate-transform-context-ignored
branch
from
55bae61
to
5b1b6b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input was ignoring custom datum transformations set in QGIS projects which may have been causing subtle shifts in on-the-fly reprojection when the default coordinate operation was different from the preferred one.