Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different text for multiple projects #733

Merged
merged 7 commits into from
May 28, 2020
Merged

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented May 26, 2020

An option to make error messages more readable, not only: invalid project

image

@tomasMizera tomasMizera self-assigned this May 26, 2020
@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-7)

@tomasMizera tomasMizera linked an issue May 26, 2020 that may be closed by this pull request
@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-7)

@tomasMizera
Copy link
Collaborator Author

@PeterPetrik @wonder-sk I changed the error propagation, what do you think about it now? isValid in LocalProjectInfo stays the same (as we discussed). This solution is up for discussion, attribute projectError needs to be reset on project sync - this bug is already on board.

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-7)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-7)

app/localprojectsmanager.cpp Outdated Show resolved Hide resolved
app/localprojectsmanager.cpp Outdated Show resolved Hide resolved
app/localprojectsmanager.h Outdated Show resolved Hide resolved
app/localprojectsmanager.cpp Outdated Show resolved Hide resolved
app/localprojectsmanager.h Outdated Show resolved Hide resolved
@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-7)

@PeterPetrik PeterPetrik merged commit 07169b9 into master May 28, 2020
@PeterPetrik PeterPetrik deleted the multiple-projects branch May 28, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show all user's mergin projects
5 participants