Fix inconsistent UI/UX for read-only non-spatial layers #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitorVieiraZ
changed the title
tomasMizera
requested changes
Oct 4, 2024
| @@ -21,6 +21,7 @@ MMComponents.MMPage { | |||
|
|
|||
| property var selectedLayer: null | |||
| property bool hasToolbar: false | |||
| property bool layerIsReadOnly: featuresModel.layer?.readOnly ?? false | |||
There was a problem hiding this comment.
It seems like we could go just with this
Suggested change
| property bool layerIsReadOnly: featuresModel.layer?.readOnly ?? false | |
| property bool layerIsReadOnly: selectedLayer?.readOnly ?? false |
that way we do not add dependency for featuresModel
|
Please rebase/merge master to fix the iOS build |
VitorVieiraZ
force-pushed
the
uiUx/readOnlyNonSpatialLayers
branch
from
b592764
to
ce28a4d
Compare
Pull Request Test Coverage Report for Build 11180907554Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
layerIsReadOnlyproperty as a condition for visibility ofAdd Featurebutton. If a layer is non-spatial and not read-only, the button will be visible.Fix #3633