Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling XLSX and DOCX files in file viewing system for newer Android versions #3524

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Jun 28, 2024

Changes in AndroidManifest.xml to ensure that newer versions of Android can open more types of documents, such as XLSX, DOCX, and PNG, provided there is an application that can open these documents. See reference.

Copy link

Pull Request Test Coverage Report for Build 9718569752

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.911%

Totals Coverage Status
Change from base Build 9678974856: 0.0%
Covered Lines: 7674
Relevant Lines: 12809

💛 - Coveralls

2 similar comments
Copy link

Pull Request Test Coverage Report for Build 9718569752

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.911%

Totals Coverage Status
Change from base Build 9678974856: 0.0%
Covered Lines: 7674
Relevant Lines: 12809

💛 - Coveralls

Copy link

Pull Request Test Coverage Report for Build 9718569752

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.911%

Totals Coverage Status
Change from base Build 9678974856: 0.0%
Covered Lines: 7674
Relevant Lines: 12809

💛 - Coveralls

@tomasMizera tomasMizera added this to the 2024.3.0 milestone Jul 1, 2024
@tomasMizera
Copy link
Collaborator

Thanks Vitor, do we know why we need to set this explicitly only for these two extensions?

@VitorVieiraZ VitorVieiraZ changed the title Handling XLSX and DOCX files in file viewing system for newer Android versions WIP - Handling XLSX and DOCX files in file viewing system for newer Android versions Jul 1, 2024
@tomasMizera tomasMizera modified the milestones: 2024.3.0, 2024.3.1 Jul 2, 2024
@tomasMizera tomasMizera modified the milestones: 2024.3.1, 2024.4.0 Jul 29, 2024
@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Jul 30, 2024
Copy link

Pull Request Test Coverage Report for Build 10164112484

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.008%) to 60.014%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/projectsmodel.cpp 5 69.44%
Totals Coverage Status
Change from base Build 10161670477: -0.008%
Covered Lines: 7704
Relevant Lines: 12837

💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP - Handling XLSX and DOCX files in file viewing system for newer Android versions Handling XLSX and DOCX files in file viewing system for newer Android versions Jul 30, 2024
@VitorVieiraZ VitorVieiraZ added enhancement android 🤖 Relates to Android app version and removed FROZEN 🥶 do not merge before upcoming release labels Jul 30, 2024
@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Aug 1, 2024
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what testing brings 🚀

@tomasMizera tomasMizera removed the FROZEN 🥶 do not merge before upcoming release label Aug 9, 2024
@tomasMizera tomasMizera merged commit 268b8cb into master Aug 9, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix/fileViewingSystemAndroid branch August 9, 2024 07:23
@alexd0793 alexd0793 added the test-success Label to use for PR testing label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android 🤖 Relates to Android app version enhancement test-success Label to use for PR testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants