-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing photo renaming with custom expressions #3514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can we add a test here please?
Pull Request Test Coverage Report for Build 9653861643Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9653861643Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9653861643Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! :)
Pull Request Test Coverage Report for Build 9678435592Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9678435592Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9678435592Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments! :)
Setting
Photo name format
inPhoto attachments configuration
previously did not accept formats beginning with '/', such as'/photos/'||@mergin_username||'-'||@layer_name||to_string("count")||'_'||format_date("date",'yyyy-MM-dd_Thh.mm.ss')
. Now, it is possible to configure expression with leading slashes. Mergin Maps will automatically remove any slashes at the beginning of the photo name format during data processing.Fixes #3415