Reintroduction of centering to GPS when starting to record new feature #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9501693256Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9501693256Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9501693256Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9503484819Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9503484819Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9503484819Details
💛 - Coveralls |
VitorVieiraZ
changed the title
tomasMizera
reviewed
Jun 14, 2024
There was a problem hiding this comment.
This is looking good, thanks @VitorVieiraZ 🚀
@uclaros can I ask you to have a look at this PR too? You were adjusting the centering logic recently :)
uclaros
reviewed
Jun 14, 2024
There was a problem hiding this comment.
What should the behavior be if location is not available yet? Just a message or should the map jump as soon as a location is available?
What should happen if the user moves before clicking record?
My take on those is that we should be setting MMMapController.centerToGPS = true, which means we get the green dot on the GPS button plus map position is updated when location is updated.
recordingMapTool.centeredToGPS seems to be bound to that so should be updated.
Pull Request Test Coverage Report for Build 9519440944Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9519440944Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9519440944Details
💛 - Coveralls |
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
Pull Request Test Coverage Report for Build 9522267694Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9522267694Details
💛 - Coveralls |
tomasMizera
requested changes
Jun 17, 2024
Pull Request Test Coverage Report for Build 9550028458Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9550028458Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9550028458Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9567578009Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9567578009Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9567578009Details
💛 - Coveralls |
tomasMizera
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Hi @uclaros, can you check once again please? It looks good to me. There is one change of logic - updatePosition() is now called after we change the state, not before. However, I could not think of a scenario where this would be an issue
uclaros
reviewed
Jun 19, 2024
app/qml/map/MMMapController.qml
Outdated
Comment on lines
97
to
101
| if ( __appSettings.autolockPosition ) { // center to GPS | ||
| if ( gpsStateGroup.state === "unavailable" ) { | ||
| __notificationModel.addError( "GPS currently unavailable." ) | ||
| return; | ||
| } |
There was a problem hiding this comment.
We completely disable recording when GPS is unavailable and autolock is on?
In that case maybe we should also handle the case when GPS is lost while recording?
There was a problem hiding this comment.
Good point, no, we need to continue even without GPS signal
app/qml/map/MMMapController.qml
Outdated
Comment on lines
144
to
146
| // We call this first because when previous state is 'view' and `centeredToGPS` is true | ||
| // the map may still not be centered. It's only centered after a certain threshold is exceeded. | ||
| updatePosition() |
There was a problem hiding this comment.
This comment is no longer true: we don't call this first, we actually call this last!
Does that mean we'll get a first point when root.recordingStarted() is called which may not be on the actual GPS position?
Why not call updatePosition() right after root.centeredToGPS = true ?
uclaros
reviewed
Jun 19, 2024
| __notificationModel.addError( "GPS currently unavailable." ) | ||
| } | ||
| else { | ||
| root.centeredToGPS = true |
There was a problem hiding this comment.
if we moved this out of the GPS availability check, does it mean the map would re-center as soon as gps position is actually available? If yes, that could be useful, but I'm OK with merging it as it is now!
There was a problem hiding this comment.
In this scenario, it would center even if the user decides to uncheck "auto-lock" property in recording settings.
There was a problem hiding this comment.
No, I mean like:
if ( __appSettings.autolockPosition ) { // center to GPS
root.centeredToGPS = true
if ( gpsStateGroup.state === "unavailable" ) {
__notificationModel.addError( "GPS currently unavailable." )
}
else {
updatePosition()
}
}
|
Unrelated test failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newGpsCenteringFeature.1.mp4
Development and functionality of the feature based on: #3506
Resolves #3506