Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing section headers' wrapping and eliding #3480

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Fixing section headers' wrapping and eliding #3480

merged 3 commits into from
Jun 5, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented May 30, 2024 •
edited
Loading

Fixes #3463

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9305865163

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 59.902%
Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginuserinfo.cpp 3 73.76%
Totals Coverage Status
Change from base Build 9274241625: -0.02%
Covered Lines: 7668
Relevant Lines: 12801
💛 - Coveralls

tomasMizera
tomasMizera reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :)

app/qml/form/MMFormPage.qml Show resolved Hide resolved
tomasMizera
tomasMizera approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@tomasMizera tomasMizera added FROZEN 🥶 do not merge before upcoming release and removed FROZEN 🥶 do not merge before upcoming release labels May 30, 2024
@tomasMizera tomasMizera merged commit 29db4a0 into master Jun 5, 2024
11 of 12 checks passed
@tomasMizera tomasMizera deleted the fix/sectionHeadersWrapping branch June 5, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form section headers do not wrap
3 participants
@VitorVieiraZ @tomasMizera @inputapp-bot