-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework MMRelationReferenceEditor #3337
Conversation
Pull Request Test Coverage Report for Build 8739567529Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments
@@ -8,38 +8,45 @@ | |||
***************************************************************************/ | |||
|
|||
import QtQuick | |||
import QtQuick.Controls | |||
//import QtQuick.Controls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup?
} | ||
|
||
onContentClicked: { | ||
textField.onReleased: { // can be opened when when the field is readonly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
textField.onReleased: { // can be opened when when the field is readonly | |
textField.onReleased: { // can be opened even when the field is readonly |
We were missing several properties to capture, it was likely not working before