Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework MMFormPhotoEditor #3332

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Rework MMFormPhotoEditor #3332

merged 4 commits into from
Apr 18, 2024

Conversation

tomasMizera
Copy link
Collaborator

image image

I moved two photo editor-related files from ./components to ./form/components/photo.
There are a bunch of things that could be changed but I think it is fine for now :)

Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, otherwise looks good!

app/qml/form/editors/MMFormPhotoViewer.qml Outdated Show resolved Hide resolved
app/qml/form/components/photo/MMPhotoAttachment.qml Outdated Show resolved Hide resolved
@tomasMizera tomasMizera changed the title Rework photo editor Rework MMFormPhotoEditor Apr 18, 2024
@tomasMizera
Copy link
Collaborator Author

@uclaros your comments should be addressed now

@tomasMizera tomasMizera merged commit f40b7a5 into rework-base-input Apr 18, 2024
11 checks passed
@tomasMizera tomasMizera deleted the rework-photo-editor branch April 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants