Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offline issues in Projects page with no/expired token #3326

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

wonder-sk
Copy link
Contributor

  1. incorrect "no workspace detected" message
  2. endless busy wait on the home tab (unable to switch projects)
  3. endless loop of requesting projects in the second tab

The hasAuthData() function is confusing - one may think it returns whether we are logged in, but in fact it only tells whether username+password have been set.

Before:

fix-offline-expired-token-before.mp4

After:

fix-offline-expired-token-after.mp4

1. incorrect "no workspace detected" message
2. endless busy wait on the home tab (unable to switch projects)
3. endless loop of requesting projects in the second tab
Copy link

Pull Request Test Coverage Report for Build 8722278224

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 194 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.3%) to 60.008%

Files with Coverage Reduction New Missed Lines %
input/app/projectsproxymodel.h 1 0.0%
input/app/projectsmodel.h 2 25.0%
input/core/project.h 2 55.56%
input/app/projectwizard.cpp 20 2.94%
input/app/projectsproxymodel.cpp 38 0.0%
input/app/projectsmodel.cpp 65 65.75%
input/app/mmstyle.h 66 2.02%
Totals Coverage Status
Change from base Build 8721422835: -0.3%
Covered Lines: 7582
Relevant Lines: 12635

💛 - Coveralls

@PeterPetrik PeterPetrik merged commit 53b2f34 into master Apr 17, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the fix-offline-expired-token branch April 17, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants