Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix photo editor #3307

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Fix photo editor #3307

merged 5 commits into from
Apr 12, 2024

Conversation

tomasMizera
Copy link
Collaborator

Fixes multiple issues with the photo editor:

  • show trash icon even when the image is not available (previously it showed the icon only when the Image was loaded successfully)
  • update the text of the MMRemovePhotoDialog to better represent what it does
  • photos were not removed from the project even if the Delete photo was selected. The issue was that the callback function onFormSaved was placed in the private QtObject and thus could not be called from the form
  • we used to call root.editorValueChanged( "", false ) where the boolean value represents if the new value is null. We were passing false even when removing the photo. Changed it to true.
Screenshot 2024-04-12 at 13 12 41

Copy link

Pull Request Test Coverage Report for Build 8661324422

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 60.073%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 74.45%
input/app/projectsmodel.cpp 5 65.75%
Totals Coverage Status
Change from base Build 8651536739: 0.03%
Covered Lines: 7586
Relevant Lines: 12628

💛 - Coveralls

@PeterPetrik
Copy link
Contributor

shouldn't unlink photo button has grape border (as secondary button)?

@PeterPetrik PeterPetrik merged commit 81df14d into master Apr 12, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the fix-photo-editor branch April 12, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants