Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app icon and splash screen #3095

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented Mar 1, 2024

We are using new API for everything :)

  • Android appicon
  • Android splash screen
  • iOS appicon
  • [½ done] iOS splashscreen - It has green color (was white previously), but the image is not visible. Needs some more debugging. I'd prefer to do it later.. maybe it is just some internal cache Working now! It was just local cache

Best to check individual commits.

See docs/howto for more details

@tomasMizera tomasMizera force-pushed the update-appicon-and-splashscreen branch from 6cbe87d to 82e850d Compare March 4, 2024 10:32
Copy link

github-actions bot commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8139446807

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 100 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.07%) to 60.051%

Files with Coverage Reduction New Missed Lines %
input/app/featuresmodel.cpp 1 69.15%
input/core/merginuserinfo.cpp 3 72.99%
input/core/merginapi.cpp 6 78.56%
input/app/androidutils.cpp 11 5.71%
input/app/notificationmodel.cpp 23 18.84%
input/app/main.cpp 56 35.0%
Totals Coverage Status
Change from base Build 8138020899: -0.07%
Covered Lines: 7543
Relevant Lines: 12561

💛 - Coveralls

@tomasMizera tomasMizera marked this pull request as ready for review March 4, 2024 11:23
@tomasMizera tomasMizera force-pushed the update-appicon-and-splashscreen branch from d50701d to 4c21f5f Compare March 4, 2024 11:25
@tomasMizera tomasMizera force-pushed the update-appicon-and-splashscreen branch from 4c21f5f to e45b06b Compare March 4, 2024 11:31
@PeterPetrik PeterPetrik merged commit 9349eba into master Mar 4, 2024
8 checks passed
@PeterPetrik PeterPetrik deleted the update-appicon-and-splashscreen branch March 4, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants