Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MigrateToMerginDialog and SplittingFailedDialog redesign #3094

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

  • MigrateToMerginDialog.qml to MMMigrateToMerginDialog.qml + adding to gallery.
  • SplittingFailedDialog.qml to MMSplittingFailedDialog.qml + adding to gallery.
  • Old dialogs cleanup.

Copy link

github-actions bot commented Mar 1, 2024

Pull Request Test Coverage Report for Build 8115351940

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 60.076%

Files with Coverage Reduction New Missed Lines %
input/app/projectsmodel.cpp 1 66.67%
input/core/merginuserinfo.cpp 3 72.99%
input/core/merginapi.cpp 6 78.56%
Totals Coverage Status
Change from base Build 8109434675: -0.06%
Covered Lines: 7545
Relevant Lines: 12559

💛 - Coveralls

title: qsTr( "Upload project to Mergin?" )
text: qsTr( "This project is currently not uploaded on Mergin. Upload it to Mergin in order to activate synchronization and collaboration. \nClick 'Yes' to upload it." )
picture: __style.positiveMMSymbolImage
bigTitle: qsTr( "Upload project to Mergin?" )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload project?

text: qsTr( "This project is currently not uploaded on Mergin. Upload it to Mergin in order to activate synchronization and collaboration. \nClick 'Yes' to upload it." )
picture: __style.positiveMMSymbolImage
bigTitle: qsTr( "Upload project to Mergin?" )
description: qsTr( "This project is currently not uploaded on Mergin. Upload it to Mergin in order to activate synchronization and collaboration." )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project is currently not uploaded on cloud. Upload it in order to activate synchronization and collaboration.

@PeterPetrik
Copy link
Contributor

very good!

@PeterPetrik PeterPetrik merged commit 3da6430 into master Mar 1, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the redesign_splitAndMigrationDlgs branch March 1, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants