Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenient base components #3091

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Add convenient base components #3091

merged 4 commits into from
Mar 1, 2024

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented Feb 29, 2024 •
edited
Loading

  • Add base MMPage
  • MMHeader with safeAreaTop
  • Add base MMDrawer
  • Add MMDrawerHeader
  • Set max height for MMDrawer to not grow over screen height

@tomasMizera tomasMizera changed the title Add MMPage, MMPageHeader and SandboxPage Add convenient base components Feb 29, 2024
iiLubos
iiLubos reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@iiLubos iiLubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice :)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8108873234

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 92 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.1%) to 60.223%
Files with Coverage Reduction New Missed Lines %
input/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
input/core/merginuserinfo.cpp 1 74.45%
input/core/merginuserinfo.h 1 0.0%
input/core/merginapi.cpp 2 78.8%
input/app/mmstyle.h 31 2.38%
input/app/main.cpp 56 35.11%
Totals Coverage Status
Change from base Build 8098639056: 0.1%
Covered Lines: 7552
Relevant Lines: 12540
💛 - Coveralls

@tomasMizera tomasMizera marked this pull request as ready for review March 1, 2024 08:56
@PeterPetrik PeterPetrik merged commit 8e48d3d into master Mar 1, 2024
10 of 11 checks passed
@PeterPetrik PeterPetrik deleted the add-convenient-components branch March 1, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iiLubos iiLubos iiLubos left review comments

@PeterPetrik PeterPetrik PeterPetrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomasMizera @PeterPetrik @inputapp-bot @iiLubos