Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recording in canvas #3081

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Recording in canvas #3081

merged 8 commits into from
Feb 28, 2024

Conversation

PeterPetrik
Copy link
Contributor

  • streaming
  • redraw
  • splitting

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8084465285

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 32 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.004%) to 60.345%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 2 78.53%
input/app/mmstyle.h 30 2.66%
Totals Coverage Status
Change from base Build 8065634782: 0.004%
Covered Lines: 7551
Relevant Lines: 12513
💛 - Coveralls

@PeterPetrik PeterPetrik changed the title WIP: recording in canvas Recording in canvas Feb 28, 2024
tomasMizera
tomasMizera approved these changes Feb 28, 2024
View reviewed changes
app/qml/main.qml
Comment on lines +548 to +550
MMStreamingModeDialog {
id: streamingModeDialog

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you want to move this to the mapwrapper?

@tomasMizera
Copy link
Collaborator

🚀

@PeterPetrik PeterPetrik merged commit adce788 into master Feb 28, 2024
10 of 11 checks passed
@PeterPetrik PeterPetrik deleted the mapmodes branch March 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterPetrik @tomasMizera @inputapp-bot