Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass keys instead of values to post-register endpoint #3073

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Feb 23, 2024

We were passing the translated string to the endpoint.

Keys are checked to match the ones also used in the web front end.

Copy link

github-actions bot commented Feb 23, 2024

Pull Request Test Coverage Report for Build 8018659219

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 60.342%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 3 74.07%
Totals Coverage Status
Change from base Build 8018321979: -0.02%
Covered Lines: 7544
Relevant Lines: 12502

💛 - Coveralls

@uclaros uclaros closed this Feb 23, 2024
@uclaros uclaros reopened this Feb 23, 2024
@PeterPetrik PeterPetrik merged commit 6964f5a into master Feb 23, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the post-register-keys branch February 23, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants