Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of the Project Issues Panel #3065

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Conversation

VitorVieiraZ
Copy link
Contributor

In progress

  • Redesign of the ProjectIssuesPanel.qml

1

Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, keep it going 👍

@@ -0,0 +1,170 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to app/qml/project/MMProjectIssuesPanel.qml

import QtQuick.Layouts
import Qt5Compat.GraphicalEffects
import lc 1.0
import "." // import InputStyle singleton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all occurrences of InputStyle

@@ -59,7 +59,7 @@ Item {

background: Rectangle {
anchors.fill: parent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file completely

app/qml/main.qml Outdated
Comment on lines 974 to 976
//projectLoadingScreen.visible = true;
projectIssuesPanel.visible = true;
//failedToLoadProjectBanner.reset();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert these changes

visible: false
property real rowHeight: InputStyle.rowHeight
property var projectIssuesModel: ListModel {}
property string projectLoadingLog: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this panel would be easy to add to gallery too if you want.

Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@PeterPetrik PeterPetrik merged commit 385ae37 into master Feb 21, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the redesign--ProjectIssuesPage branch February 21, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants