Map view visual redesign #3017
Merged
Map view visual redesign #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
reviewed
Jan 19, 2024
| Q_INVOKABLE void add( const QString &message, uint interval, NotificationType::MessageType type, NotificationType::IconType icon ); | ||
|
|
||
| //! Convinient methods to save typing of some parameters | ||
| Q_INVOKABLE void addSuccess( const QString &message ); |
There was a problem hiding this comment.
at least I would add expiration time here with default NotificationModel::DEFAULT_NOTIFICATION_EXPIRATION_SECS
There was a problem hiding this comment.
I prefer not going down that path, we can instead define additional methods also with expiration. QML/JS engine does not work well with C++'s default arguments or method overloads.
| @@ -262,7 +262,7 @@ Item { | |||
| }, | |||
| State { | |||
| name: "notAtTarget" | |||
| when: state != "atTarget" | |||
| when: state !== "atTarget" | |||
There was a problem hiding this comment.
Not necessarily, it was JS warning. This way it won't perform type coercion https://medium.com/@atuljha2402/understanding-javascript-type-coercion-type-conversion-a2ce84c00331#:~:text=Comparison%20Coercion%3A
PeterPetrik
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated map view to the new design:
Highlight will be added in another PR
Best to go over commits one by one :)