Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base new design of Project item #2938

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Conversation

iiLubos
Copy link
Contributor

@iiLubos iiLubos commented Dec 4, 2023

ProjectItem

Added:

  • MMProjectItem: Project item
  • MMListDrawer: Whole menu of project items (it should be a common item)
  • MMListDrawerItem: One item from a menu list (it should be a common item)
    MMProjectItem {
      width: 350
      highlight: true
      projectId: "1"
      projectStatus: 2
      projectDisplayName: "Mergin local project"
      projectDescription: "Highlighted"
      projectIsValid: true
      projectIsLocal: true
      projectIsMergin: true
      projectIsPending: true
      onOpenRequested: console.log("onOpenRequested")
      onStopSyncRequested: projectIsPending = false
      onShowChangesRequested: console.log("onShowChangesRequested")
      onSyncRequested: projectIsPending = true
      onRemoveRequested: console.log("onRemoveRequested")
      onMigrateRequested: console.log("onMigrateRequested")
    }

Note: Names of properties and signals used from the current project item

@iiLubos iiLubos marked this pull request as ready for review December 7, 2023 23:10
@iiLubos iiLubos changed the base branch from master to dev-redesign December 7, 2023 23:12
Copy link

github-actions bot commented Dec 7, 2023

Pull Request Test Coverage Report for Build 7164183763

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 61.974%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 76.34%
Totals Coverage Status
Change from base Build 7125268692: 0.1%
Covered Lines: 7541
Relevant Lines: 12168

💛 - Coveralls

@PeterPetrik PeterPetrik merged commit 097422d into dev-redesign Dec 11, 2023
11 checks passed
@PeterPetrik PeterPetrik deleted the dev-redesign_ProjectItem branch December 11, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants