Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position tracking (0,0) coordinates on Android - fix locale when writing decimals #2881

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

tomasMizera
Copy link
Collaborator

🫢 Java's String::format uses a default locale when no locale is provided to it. It means that for US/UK locale it used . as the decimal separator. However, for example for SK, it used , -> Qt was unable to parse double with such decimal separator aaaand 💥

We will use the common Locale.US for writing doubles. A workaround until this bug is released is to change the system language to English 🇬🇧🇺🇸 ... or some other place where they use . as decimal separator

Resolves #2781

See https://developer.android.com/reference/java/util/Locale#default_locale:~:text=Be%20wary%20of%20the%20default%20locale

I checked other occurrences of String::format but they look alright.

@tomasMizera tomasMizera merged commit 80db5ad into master Oct 30, 2023
10 checks passed
@tomasMizera tomasMizera deleted the fix-tracking-locale branch October 30, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position tracking results in line feature with points of coordinates 0, 0 (system origin)
3 participants