Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show migration dialogue #2791

Merged
merged 8 commits into from
Nov 10, 2023
Merged

Show migration dialogue #2791

merged 8 commits into from
Nov 10, 2023

Conversation

iiLubos
Copy link
Contributor

@iiLubos iiLubos commented Sep 14, 2023

CU-861n8yh4d Show migration dialogue when Legacy CE servers version is lower than 2023.2.0

MigrationDialog

When the Ignore button is pressed this dialog will not be shown for the current version anymore

core/merginapi.cpp Outdated Show resolved Hide resolved
core/merginapi.h Outdated Show resolved Hide resolved
MINIMUM_SERVER_VERSION_MAJOR/MINOR
core/merginapi.cpp Outdated Show resolved Hide resolved
core/merginapi.cpp Outdated Show resolved Hide resolved
core/merginapi.cpp Show resolved Hide resolved
@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Sep 27, 2023
@PeterPetrik PeterPetrik removed the FROZEN 🥶 do not merge before upcoming release label Oct 24, 2023
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @iiLubos , can you please fix conflicts? We can merge it then

app/qml/main.qml Outdated Show resolved Hide resolved
app/qml/main.qml Outdated Show resolved Hide resolved
@tomasMizera tomasMizera added the ready-for-testing Ready to be tested by testers crew - passed review by devs label Nov 8, 2023
@tomasMizera
Copy link
Collaborator

@jozef-budac Let me know when you are ready to test this, I can help you to set it up :)

@tomasMizera
Copy link
Collaborator

We will merge this so that CI runs

@tomasMizera tomasMizera merged commit 7c27b43 into master Nov 10, 2023
9 checks passed
@jozef-budac
Copy link

@tomasMizera I just verified it works as expected

@iiLubos iiLubos deleted the master_migration branch November 14, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing Ready to be tested by testers crew - passed review by devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "ignore" button to outdated server dialog
5 participants