Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract value relations #1664

Merged
merged 6 commits into from
Oct 1, 2021
Merged

Extract value relations #1664

merged 6 commits into from
Oct 1, 2021

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented Sep 29, 2021

This PR extracts ValueRelationFeaturesModel from previous FeaturesListModel that contained overcomplicated logic mixing logic for BrowseData and ValueRelations in one class. FeaturesListModel is also a base class for RelationFeaturesModel and RelationReferenceFeaturesModel as it can be seen on image below.

ValueRelation-, Relation- and RelationReference- FeaturesModels are used in respective form editors to list features from desired layers. They override several methods from base class like methods that set up feature request, title field or general setup method where configs are parsed.

featuresModels

Resolves #1640

  • add test for ValueRelationFeaturesModel
  • add test for FeaturesModel

Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a brief read. 👏

app/featuresmodel.h Outdated Show resolved Hide resolved
app/featuresmodel.h Outdated Show resolved Hide resolved
app/featuresmodel.h Outdated Show resolved Hide resolved
app/featuresmodel.h Outdated Show resolved Hide resolved
app/featuresmodel.h Outdated Show resolved Hide resolved
app/inpututils.cpp Outdated Show resolved Hide resolved
app/valuerelationfeaturesmodel.h Outdated Show resolved Hide resolved
app/featuresmodel.cpp Outdated Show resolved Hide resolved
app/inpututils.cpp Outdated Show resolved Hide resolved
@tomasMizera tomasMizera added the blocked Not possible to continue until other task is resolved label Sep 29, 2021
@tomasMizera
Copy link
Collaborator Author

tomasMizera commented Sep 29, 2021

Please do not merge, I found one issue that needs to be fixed! Value relation fields are sometimes losing text (when opened in readonly mode)

@tomasMizera tomasMizera removed the blocked Not possible to continue until other task is resolved label Sep 30, 2021
@PeterPetrik PeterPetrik merged commit 8e10140 into master Oct 1, 2021
@PeterPetrik PeterPetrik deleted the 1640-features-models branch October 1, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value relations after forms refactoring
4 participants