Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict "non searchable" attributes in a feature request query #1372

Merged
merged 1 commit into from
May 5, 2021

Conversation

sklencar
Copy link
Contributor

@sklencar sklencar commented May 3, 2021

Attributes marked as not searchable are filtered out from QgsFeature request (scope) as well as from informative text for features shown on the BrowseDataPage.

Note that values for such attributes are still present in features fetched from the request (request.subsetOfAttributes() is kept unset and therefore a user see all attributes while browsing).

PR for QgsQuick will be made after this PR would be approved.

closes #1354

@sklencar sklencar requested a review from PeterPetrik May 3, 2021 14:16
@PeterPetrik
Copy link
Contributor

@sklencar can you add manual test?

Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@PeterPetrik
Copy link
Contributor

lutraconsulting/input-manual-tests#6 Test D

@sklencar or @saberraz can you also fix the input-docs to add how to configure not searchable columns? thanks

@PeterPetrik PeterPetrik merged commit d613a86 into master May 5, 2021
@PeterPetrik PeterPetrik deleted the 1354_nonSearchable_attributes branch May 5, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search configuration in QGIS layer properties
3 participants