Fixed behaviour of TextField in ProjectWizard #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jozefbudac Could you please test it and possibly confirm if it also fixed for the reported issue? |
PeterPetrik
requested changes
May 5, 2021
PeterPetrik
reviewed
May 5, 2021
app/qml/components/FieldRow.qml
Outdated
Comment on lines
33
to
34
| Component.onCompleted: text = AttributeName | ||
| onDisplayTextChanged: AttributeName = displayText |
There was a problem hiding this comment.
http://imaginativethinking.ca/bi-directional-data-binding-qt-quick/
instead of onDisplayTextChanged signal it is better to do binding AttributeName = textField.text
There was a problem hiding this comment.
Changed for simple textChanged signal handling
|
Tried it with lastest APK and it works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't replicate the issue, but I could replicate similar problem with auto uppercase - when a user types into an Attribute field with fixed uppercase option (usually double click on shift to "lock" shift), it always switches back to lower case. It doesn't happen for a project name field.
This PR fixes the issue described above. However, the reported issue could be very related and fixed as well. Best to test.
Now the field value is bound to
textwithout an extra handling for displayText.closes #1334