-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accuracy warning while recording a feature #1221
Conversation
Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saberraz For time-being, the link in the warning takes a user to |
@sklencar could you point it to https://help.inputapp.io/howto/gps_accuracy |
I would suggest few more changes:
|
d73fb4e
to
3ac2bf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, it is working very well!
I would maybe change the text so that it is clear why we ask user to have a nice view of the sky (there is now nothing written about GPS accuracy), but for sure @mostlyAtNight will come up with something :)
Other than that, I am ok to merge!
@sklencar ah yes can we please keep also the first sentence ( Looks like there are also some conflicts now from the other merges - could you please rebase? |
af7c4f2
to
f706ac8
Compare
Added additional text to banner |
Banner has still simple design with suggested colors. Would be good to ask Rado for a desing.
This PR also stressed #1225 even more.
closes #1192