Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfinished project download may leave incomplete directory #884

Closed
wonder-sk opened this issue Sep 23, 2020 · 2 comments · Fixed by #915
Closed

Unfinished project download may leave incomplete directory #884

wonder-sk opened this issue Sep 23, 2020 · 2 comments · Fixed by #915
Assignees
Labels
bug sync Integration with Mergin Maps backend

Comments

@wonder-sk
Copy link
Contributor

Download of a project may get interrupted, even without getting a signal about the failure of a request.

This will leave a half-populated directory and may cause further trouble later.

We should have a mechanism that will ensure that half-downloaded projects are never shown in the list - and any half-downloaded project data get pruned. For example, we could download to a dir with a special prefix, and directories with such prefix would be never shown (+would get deleted when Input starts)

TODO: find out when exactly this happens (app gets to background? app is forcefully quit?)

@wonder-sk wonder-sk added bug sync Integration with Mergin Maps backend labels Sep 23, 2020
@tomasMizera tomasMizera self-assigned this Sep 28, 2020
@tomasMizera
Copy link
Collaborator

@tomasMizera
Copy link
Collaborator

Upon investigating I found out that failed download (only when application quits) keeps the directory. When opening app again it lists the project with error. Next time trying to download creates new directory with 0,1,2... at the end based on how many times it failed already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug sync Integration with Mergin Maps backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants