Fix not null value relation (#3446)

MerginMaps · May 23, 2024 · e952599 · e952599 · inputapp-bot · May 23, 2024
1 parent baf5c4c
commit e952599
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/app/qml/form/editors/MMFormValueRelationEditor.qml b/app/qml/form/editors/MMFormValueRelationEditor.qml
@@ -74,15 +74,6 @@ MMFormComboboxBaseEditor {
       valueRole: "FeatureId"
       textRole: "FeatureTitle"
 
-      selected: {
-        if ( internal.allowMultivalue ) {
-          return vrModel.convertFromQgisType( root._fieldValue, MM.FeaturesModel.FeatureId )
-        }
-        else {
-          return [root._fieldValue]
-        }
-      }
-
       list.model: MM.ValueRelationFeaturesModel {
         id: vrDropdownModel
 
@@ -120,7 +111,16 @@ MMFormComboboxBaseEditor {
         close()
       }
 
-      Component.onCompleted: open()
+      Component.onCompleted: {
+        // We want to set the initial value of 'selected' property but not bind it so we avoid a binding loop
+        if ( internal.allowMultivalue ) {
+          selected = vrModel.convertFromQgisType( root._fieldValue, MM.FeaturesModel.FeatureId )
+        }
+        else {
+          selected = [root._fieldValue]
+        }
+        open()
+      }
     }
   }