Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage support #11

Closed
raulriera opened this issue Feb 1, 2015 · 16 comments
Closed

Carthage support #11

raulriera opened this issue Feb 1, 2015 · 16 comments

Comments

@raulriera
Copy link

Supporting Cocoapods (http://cocoapods.org) and/or Carthage (https://github.com/Carthage/Carthage) is great for libraries. It might not be the easiest thing for "new comers", but for the rest is a must

@MengTo
Copy link
Owner

MengTo commented Feb 1, 2015

Definitely working on this! :D

@clooth
Copy link

clooth commented Feb 4, 2015

I manage to get it working with Carthage by setting the Spring.framework's scheme as shared in Xcode and then tagging the version on my fork of Spring. (https://github.com/clooth/Spring/tree/1.0.1)

@jamztang
Copy link
Contributor

jamztang commented Feb 8, 2015

The merge is going well to have Carthage recognise and build the framework correctly.

However, I had issues with integrating this way is that SpringView's IBInspectable are not correctly showing up in the view properties panel. Classes are also not auto filled when I typed into the custom class textfield on a view. Anyone had some pointers?

@raulriera
Copy link
Author

This merge is not in the master branch right? I get a Project "SpringApp.xcodeproj" has no shared schemes error when trying to use it.

There is no "release" for this yet in the tags

@schneiderandre
Copy link
Contributor

@raulriera yes, the 1.0.0 tag was created before #13 was merged.
I'm not sure why Carthage uses tag 1.0.1 for me, but this works. I'll talk to @jamztang and @MengTo and we will either move the tag or create a new one.

@jamztang
Copy link
Contributor

I've moved 1.0.0 from 9ac47a4 to 490a266, let me know if this works for you guys!

@raulriera
Copy link
Author

You are correct, they don't show up in the properties inspector, nor they autocomplete in the Custom Class section of a view, but they do show in the code normally if I import Spring

Might be an issue with Carthage?

@jamztang
Copy link
Contributor

Thanks for filing an issue on Carthage. Yeah we didn't have the same problem with other Integration methods, have you seen projects works with IB correctly using Carthage?

@raulriera
Copy link
Author

Not at the moment no, the two I put in there are the only UI ones I have seen so far

@jamztang
Copy link
Contributor

Right, thanks @raulriera, we'll keep an eye on the Carthage issue and see what we can do!

@raulriera
Copy link
Author

After some testing out I noticed that the framework is stripping out the initialisers from classes and this is why they are not accessible via Storyboard.

For my project, if you do a Carthage (or a normal framework build) and then import the framework into any project, CMD + clicking into the import yourFramework shows you the lists of methods available, and some of the initialisers disappeared.

I am unable to solve this on my own project, but maybe this can give you some idea

@jamztang
Copy link
Contributor

jamztang commented Mar 6, 2015

That sounds like a good hint, thanks @raulriera. We'll come back to this.

@schneiderandre
Copy link
Contributor

I tried it again in Xcode Version 6.4 (6E35b) with Carthage and also with a manual Framework Build, but it seems that the issues with the Designables/Inspectables in embedded Binaries still exist.

@raulriera
Copy link
Author

Yes, this bug persists in Xcode 7 I opened this (but for real on Apple's) http://www.openradar.me/radar?id=5031199516917760 and it was marked as duplicate.. so at least someone looked at it

@schneiderandre
Copy link
Contributor

Thanks for the update 👍. Good to hear that they are aware of this.

@schneiderandre
Copy link
Contributor

I will close this for now, since it sounds like an Xcode issue 😞.
Feel free to reopen this if you have any new insights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants