Resolves #18, upgraded to work with Angular 6+ #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the ng-canvas-guages library project and a demo project.
and contents from being included in
wayneparrott
commented
Feb 28, 2019
There was a problem hiding this comment.
I realize my changes are very broad and not backward compatible before Angular 6. If they are too broad or don't align with your expectations just let me know how to proceed. I'm already using this implementation in a real-time angular 7 dashboard to good effect.
|
Apologies for the goofed up commits. I realized that I had omitted the @input options implementation. So I've rolled that into this PR for your considerations. |
|
@wayneparrott , thank you for the fantastic job putting all of this together. Didn't have a chance to support this library for a long period of time. |
|
thx for merging. I have a few more mods since this PR that I would like to submit - small stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a full project revamp based on the ng6+ workspace layout including the ng-canvas-guages library project and a demo project. Key implementations changes include:
1 - new options implementation replaces polling (AfterViewChange) with event-based strategy (MutationObserver)
2 - added BaseGauge.update(T2)
3 - tooling such as VS Code & CodeMix can now provide codeassist for options
Tested with Angular 6.2 and 7.3.