[fix/response-transformer] fix for issue #393 #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashiranjan84
force-pushed
the
fix/response-transformer
branch
from
56e9740
to
a585fce
Compare
| if json_body ~= nil then | ||
|
|
||
| -- remove key:value to body | ||
| for _, name, value in iter(conf.remove.json) do |
There was a problem hiding this comment.
value is never used, isn't the linter complaining?
subnetmarco
changed the title
| return stringy.startswith(content_type, APPLICATION_JSON) | ||
| end | ||
| return false | ||
| end |
There was a problem hiding this comment.
This function should probably be implemented the same way as the one in body_transformer.
shashiranjan84
force-pushed
the
fix/response-transformer
branch
3 times, most recently
from
1dadc3c
to
a03eb07
Compare
|
LGTM too |
thibaultcha
added
pr/ready (but hold merge)
shashiranjan84
force-pushed
the
fix/response-transformer
branch
from
a03eb07
to
f606d4f
Compare
shashiranjan84
added
pr/status/needs review
and removed
pr/ready (but hold merge)
|
@thibaultcha PR need to be reviewed as I notice a bug in my code. I have made the change and added test. |
Now add will only add header/json if it does not exist, config `append` added to support adding new value to existing header/json. If header does not exist, a new one will be added. config `replace added to replace the value of existing header/json with new value
shashiranjan84
force-pushed
the
fix/response-transformer
branch
from
f606d4f
to
7b7d388
Compare
|
Should have been a new commit to distinguish it |
thibaultcha
added a commit
that referenced
this pull request
Dec 25, 2015
[fix/response-transformer] fix for issue #393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now add will only add header/json if it does not exist, config
appendadded to support adding new value to existing header/json. If header does not exist, a new one will be added. config `replace added to replace the value of existing header/json with new value