Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update exception handling and improve logging #1399

Merged
merged 8 commits into from
Dec 24, 2023

Conversation

MartinWitt
Copy link
Owner

No description provided.

Introduced new Sidebar component and simplified PageLayout component by using the new Sidebar instead of Navigation component. Added new dependencies (@react-buddy/ide-toolbox and @react-buddy/palette-mui) in package.json and updated package-lock.json accordingly. The LoginButton component was also updated to accept styling props.
This update expands the ESLint configuration to cover TypeScript files, refines the ESLint dependencies and versions, and integrates ESLint with Vite. It also modifies related configurations in the frontend package.json and vite.config.ts files.
The main changes in this commit involve exception handling and logging in the MiningStartup and ProjectSupplier classes. Now, an IllegalStateException is thrown when no known projects are found. Logging has been updated to use the Quarkus Log instead of System.out.println for better log control and readability. Minor changes include the revision of dependencies and test code formatting.
Copy link

gitstream-cm bot commented Dec 24, 2023

This PR is 42.857142857142854% new code.

Copy link
Contributor

github-actions bot commented Dec 24, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.0
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@MartinWitt MartinWitt merged commit aa6bd8e into master Dec 24, 2023
9 checks passed
@MartinWitt MartinWitt deleted the fix/vertxExceptionhandler branch December 24, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant