Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compilation of FW with 2 extruders. #26833

Closed
1 task done
radek8 opened this issue Mar 2, 2024 · 7 comments · Fixed by #26834
Closed
1 task done

[BUG] Compilation of FW with 2 extruders. #26833

radek8 opened this issue Mar 2, 2024 · 7 comments · Fixed by #26834

Comments

@radek8
Copy link
Contributor

radek8 commented Mar 2, 2024

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I have a printer with 2 nozzles. I regularly update to new versions.
Now the compilation ends with an error.
I found that it brought the error
#26152

Bug Timeline

24.1.2024

Expected behavior

Compilation of FW

Actual behavior

Compilation error

image

After commenting this line
u8g.drawBitmapP(_MAX(0, STATUS_HOTEND_X(heater_id) - 6), STATUS_HEATERS_Y + 3, 1, 5, status_active_extruder_indicator_bmp);
in the status_screen_DOGM.cpp file, the compilation will succeed

Steps to Reproduce

No response

Version of Marlin Firmware

bugfix 2.1.x

Printer model

Ender3 - modified

Electronics

SKR V1.4 Turbo

LCD/Controller

BTT TFT 3.5 E3 V3.0

Other add-ons

Print head - pendulum

Bed Leveling

ABL Linear grid

Your Slicer

Cura

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

config.zip

@thisiskeithb
Copy link
Member

Your config does not compile with stock Marlin, so please attach your modified pins file / any other modified files:

Marlin/src/HAL/shared/../../inc/SanityCheck.h:714:6: error: #error "SERVO1_PIN must be defined for your SWITCHING_NOZZLE."
  714 |     #error "SERVO1_PIN must be defined for your SWITCHING_NOZZLE."
      |      ^~~~~
Marlin/src/HAL/shared/../../inc/SanityCheck.h:756:6: error: #error "SERVO1_PIN must be defined for your SWITCHING_EXTRUDER."
  756 |     #error "SERVO1_PIN must be defined for your SWITCHING_EXTRUDER."
      |      ^~~~~
Marlin/src/HAL/LPC1768/../../inc/SanityCheck.h:964:26: error: static assertion failed: NUM_SERVOS (or some servo index) is too large. The selected board only has 1 servos.

@radek8
Copy link
Contributor Author

radek8 commented Mar 2, 2024

Pins.zip

@thisiskeithb
Copy link
Member

I had to disable SHOW_CUSTOM_BOOTSCREEN, but I can now reproduce the error message.

Disable STATUS_HOTEND_NUMBERLESS and it'll compile.

@radek8
Copy link
Contributor Author

radek8 commented Mar 2, 2024

It works.
I really wouldn't have found this on my own.
Thank you for your time.
Maybe the bug could point this out so that other users are also alerted.

@radek8 radek8 changed the title [BUG] Compilation of WF with 2 extruders. [BUG] Compilation of FW with 2 extruders. Mar 2, 2024
@thisiskeithb
Copy link
Member

Alternatively, you can leave STATUS_HOTEND_NUMBERLESS enabled and patch status_screen_DOGM.cpp:

diff --git a/Marlin/src/lcd/dogm/status_screen_DOGM.cpp b/Marlin/src/lcd/dogm/status_screen_DOGM.cpp
index 2416501..e77a0f1 100644
--- a/Marlin/src/lcd/dogm/status_screen_DOGM.cpp
+++ b/Marlin/src/lcd/dogm/status_screen_DOGM.cpp
@@ -323,7 +323,7 @@ FORCE_INLINE void _draw_centered_temp(const celsius_t temp, const uint8_t tx, co
 
       } // PAGE_CONTAINS
 
-      #if HAS_MULTI_EXTRUDER && DISABLED(SLIM_LCD_MENUS)
+      #if HAS_MULTI_EXTRUDER && NONE(SLIM_LCD_MENUS, STATUS_HOTEND_NUMBERLESS)
         if (active_extruder == heater_id)
           u8g.drawBitmapP(_MAX(0, STATUS_HOTEND_X(heater_id) - 6), STATUS_HEATERS_Y + 3, 1, 5, status_active_extruder_indicator_bmp);
       #endif

I'll submit a PR with this patch shortly.

@thisiskeithb
Copy link
Member

PR submitted, so please give #26834 a try.

Copy link

github-actions bot commented May 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants