-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append SpecLibFlat libraries #221
base: development
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
# increment flat fragment indices | ||
for fragment_flat_df in ["_fragment_df"]: | ||
if ( | ||
hasattr(self, fragment_flat_df) | ||
and len(getattr(self, fragment_flat_df)) > 0 | ||
): | ||
frag_idx_increment = len(getattr(self, fragment_flat_df)) | ||
|
||
if "flat_frag_start_idx" in other_df.columns: | ||
other_df["flat_frag_start_idx"] += frag_idx_increment | ||
|
||
if "flat_frag_stop_idx" in other_df.columns: | ||
other_df["flat_frag_stop_idx"] += frag_idx_increment | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this copies the above logic .. shouldnt this better be generalized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR allows to append purely flat (only
fragment_df
) as well as hybrid (fragment_mz_df
+fragment_df
)SpecLibFlat
libraries.