Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm-shrinkwrap - force gulp-header to 1.8.2 for gulp-angular-templatecache #66

Merged
merged 1 commit into from
Jun 17, 2016
Merged

npm-shrinkwrap - force gulp-header to 1.8.2 for gulp-angular-templatecache #66

merged 1 commit into from
Jun 17, 2016

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Jun 17, 2016

this is to fix gulp-community/gulp-header#37:

  • gulp-angular-templatecache depends on gulp-header 1.x
  • gulp-header 1.8.3 tries to lstat before writing and fails

which leads gulp templatecache to fail with ENOENT on the file it's trying to write to.. :)

@simaishi , @Fryguy ..

…cache

this is to fix gulp-community/gulp-header#37:
  gulp-angular-templatecache depends on gulp-header 1.x
  gulp-header 1.8.3 tries to lstat before writing and fails

which leads `gulp templatecache` to fail with ENOENT on the file it's trying to write to.. :)
@Fryguy
Copy link
Member

Fryguy commented Jun 17, 2016

👍 LGTM cc @chessbyte This is marked blocker as builds are broken without it.

@miq-bot
Copy link
Member

miq-bot commented Jun 17, 2016

Checked commit https://github.com/himdel/manageiq-ui-self_service/commit/9f8f4a2200b01e30acc696342f87ecdfd823d09f with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🍪

@Fryguy Fryguy merged commit 2538a71 into ManageIQ:master Jun 17, 2016
chessbyte pushed a commit that referenced this pull request Jun 17, 2016
npm-shrinkwrap - force gulp-header to 1.8.2 for gulp-angular-templatecache
(cherry picked from commit 2538a71)
@himdel himdel deleted the fix-build-enoent branch June 17, 2016 20:20
@chessbyte chessbyte added this to the Sprint 42 Ending June 20, 2016 milestone Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.8.3 throws an exception
4 participants