-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds yarn, updates travis to install using yarn #252
Adds yarn, updates travis to install using yarn #252
Conversation
Yarn does not yet jive with bower, when it does this build step will be removed: yarnpkg/yarn#896
Checked commit AllenBW@7d5d0d3 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
@chriskacerguis Looks like this is a done deal. |
Hi @AparnaKarve yes, that is correct (the readme is updated). |
@AparnaKarve you're correct, We aren't exactly using yarn instead npm. npm is still very much involved in the app, you could think of yarn as an package.json manager. |
@AllenBW I'm seeing a And another thing, should we remove |
@himdel Thanks for the feedback!! So first point, do we need the shrinkwrap anymore? (After removing the file and running yarn install again) ☝️ so you mind if i axe the file in question? Second point, SO a cool thing yarn does is |
Right.. looking at the issue that caused us to have npm-shrinkwrap in the first place (gulp-community/gulp-header#37), it's resolved and probably only affected gulp-header 1.8.3, so 1.8.8 should be fine. So feel free to completely and utterly destroy And if the scripts are planned to be supported, then sure, let's keep them :) |
` error npm-shrinkwrap.json found. This will not be updated or respected. See [TODO] for more information.` As per ManageIQ#252
Yarn does not yet jive with bower, when it does this build step will be removed: yarnpkg/yarn#896
Added gulp-imagemin optional dependencies
closes #245
@chriskacerguis @himdel