Lock down es-abstract to avoid build issues on s390x #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
added a commit
to bdunne/manageiq-rpm_build
that referenced
this pull request
Aug 1, 2023
Yarn 1 needs to rewrite the lockfile es-abstract is locked down by ManageIQ/manageiq-ui-service#1857
|
Checked commits bdunne/manageiq-ui-service@cf484a2~...710ecc4 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Aug 2, 2023
Lock down es-abstract to avoid build issues on s390x (cherry picked from commit cab1c3e)
Fryguy
added a commit
to Fryguy/manageiq-ui-service
that referenced
this pull request
Dec 7, 2023
Now that we are on yarn 4.0.2, which can support newer versions of es-abstract on s390x, this commit reverts all of the lockdowns to packages for that reason. This commit reverts cf484a2 (ManageIQ#1857), 95f6c55/68335b56 (ManageIQ#1860), and d72356f (ManageIQ#1861)
Merged
Fryguy
added a commit
to Fryguy/manageiq-ui-service
that referenced
this pull request
Dec 7, 2023
Now that we are on yarn 4.0.2, which can support newer versions of es-abstract on s390x, this commit reverts all of the lockdowns to packages for that reason. This commit reverts cf484a2 (ManageIQ#1857), 95f6c55 / 68335b5 (ManageIQ#1860), and d72356f (ManageIQ#1861)
Fryguy
added a commit
to Fryguy/manageiq-ui-service
that referenced
this pull request
Dec 7, 2023
Now that we are on yarn 4.0.2, which can support newer versions of es-abstract on s390x, this commit reverts all of the lockdowns to packages for that reason. This commit reverts cf484a2 (ManageIQ#1857), 95f6c55 / 68335b5 (ManageIQ#1860), and d72356f (ManageIQ#1861)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ManageIQ/manageiq-rpm_build#409