Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[WIP] Add ComparableMixin to InfraVMsCollection and add compare vms test utilizing the mixin. #10054

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

[WIP] Add ComparableMixin to InfraVMsCollection and add compare vms test utilizing the mixin. #10054

wants to merge 23 commits into from

Conversation

prichard77
Copy link
Contributor

@prichard77 prichard77 commented Apr 15, 2020 •
edited
Loading

Purpose or Intent

  • __Adding tests__to utilize ComparableMixin for VM Collections.
    This contains commits from PR#9912

PRT Run

@dajoRH dajoRH added the WIP label Apr 15, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Apr 15, 2020

I detected some fixture changes in commit a02a91aa2affd1285621bffce94a2940445cca5d

The local fixture setup_provider_min_vms is used in the following files:

  • cfme/tests/infrastructure/test_vm_compare.py
    • test_compare_vms

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@dajoRH
Copy link
Contributor

dajoRH commented Apr 15, 2020

Lint report for commit a02a91aa2affd1285621bffce94a2940445cca5d:

cfme/tests/infrastructure/test_providers.py:

  • ‼️ Line 535:1: E302 expected 2 blank lines, found 1

Please, rectify these issues 😏 .

No commit flaws detected.

CFME QE Bot

@dajoRH
Copy link
Contributor

dajoRH commented May 12, 2020

Would you mind rebasing this Pull Request against latest master, please? :trollface:
CFME QE Bot

@prichard77
Add partial draft of compare_host so can move to another PR
6856a36
@prichard77
Fix flake8 so Mr. Eastwood will go away
1b4fc1f
@prichard77
Make more flake8 updates
acc9dd2
@prichard77
Add to HostCompareView.is_displayed to support nav from the all hosts…
765630a 
… view
@prichard77
Add toolbar items to HostsCompareView and make ProviderHostsCompareVi…
21a485b 
…ew inherit from it
@prichard77
Add compare_hosts and implement in compare tests and add additional t…
38437d5 
…ests
@prichard77
Add temp draft of ComparableCommonBase and ComparableCommonBase and c…
5888a97 
…ompare_hosts method
@prichard77
Update compare_entities to check type of entity and be generic for en…
99a64bf 
…tities
@prichard77
Add Comparable and DROPDOWN_TEXT to VM
d083188
@prichard77
Fix flake8
3331eac
@prichard77
Replace compare_entities with compare_entities_col containing newest …
f7103f6 
…code with collection support
@prichard77
Add create_view code for when app_col is True
8da1162
@prichard77
Fix Flake8
0a811a2
@prichard77
Update Comparable order in VM and rename ComparableMixin
e10ed48
@prichard77
Update Comparable to ComparableMixin
1eb4dec
@prichard77
Add constants to ComparableMixin, removed app_col kwarg and usage, an…
a8346bc 
…d created ComparView
@prichard77
Remove ComparableMixin from VM, removed DROPDOWN_TEXT from HostsColle…
80de11e 
…ction
@prichard77
Update self.paerent logic in ComparableMixin and undo changes used fo…
889ee23 
…r debug
@prichard77
Add name property to InfraTemplateCollection and filter to instance i…
b8c040c 
…n test_compare_provider_templates
@prichard77
Fix flake8
9927709
@prichard77
Remove TemplatesAll2 and add its functionality to TemplatesAll
57d9eff
@prichard77
Add constants and assoc docblock text to ComparableMixin
84e217c
@prichard77
Update imports and body of test_compare_vms to use Comparable
b24348a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-lint needs-rebase WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prichard77 @dajoRH