Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not only support instructions coverage, but also line coverage #36

Open
sgc109 opened this issue Dec 30, 2022 · 3 comments
Open

Not only support instructions coverage, but also line coverage #36

sgc109 opened this issue Dec 30, 2022 · 3 comments
Assignees
Labels
feature request New feature or request incubation Features that are under discussion
Milestone

Comments

@sgc109
Copy link

sgc109 commented Dec 30, 2022

It seems like jacoco-report using instructions counters in a report Jacoco generated to calculate the entire coverage.

Can't I change this to use line counters?

@thsaravana thsaravana self-assigned this Jul 22, 2023
@thsaravana thsaravana added feature request New feature or request incubation Features that are under discussion labels Jul 22, 2023
@thsaravana thsaravana added this to the 1.6 milestone Jul 22, 2023
@thsaravana
Copy link
Member

Sadly there is no way to configure this right now. But I am thinking of adding an option to configure this. I will add more info here soon.

@thsaravana
Copy link
Member

I am rethinking again how we can do this effectively. As far as I checked, INSTRUCTIONS seems to be more accurate than LINE counter. We have the LINE counter for File, Module and Project level, but not at Line level. For each Line, we have INSTRUCTION and BRANCH but not Line.
So how do we determine if a Line is covered or not? For now, we depend on INSTRUCTION. But this also is not fully correct. We can have a Line that has a BRANCH but no INSTRUCTION.

🤔

@thsaravana thsaravana modified the milestones: 1.6, 1.7 Jul 30, 2023
@gokhan-oner
Copy link

@thsaravana Jacoco itself reports instruction & branch coverage, so I suggest adding support for branch coverage, rather than line coverage. As you said, if it was accurate, I'd assume Jacoco itself will visualize it anyways!

@thsaravana thsaravana modified the milestones: 1.7, 1.7.3 Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request incubation Features that are under discussion
Projects
None yet
Development

No branches or pull requests

3 participants