Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #74 #75

Merged
merged 3 commits into from
Sep 22, 2020
Merged

fixes #74 #75

merged 3 commits into from
Sep 22, 2020

Conversation

fosterfarrell9
Copy link
Collaborator

This should fix #74 (and make the code a little cleaner along the way).

henrixapp
henrixapp reviewed Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@henrixapp henrixapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rename one function.

app/controllers/application_controller.rb Outdated Show resolved Hide resolved
henrixapp
henrixapp suggested changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@henrixapp henrixapp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The set_localemethod still calls the old cookie_param, so the cookie will be never considered.

@fosterfarrell9
Copy link
Collaborator Author

Oops.

@fosterfarrell9 fosterfarrell9 merged commit 61838ad into master Sep 22, 2020
@christian-heusel christian-heusel deleted the fix-locale-crash branch November 14, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrixapp henrixapp henrixapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty locale cookie crashes rendering
2 participants
@fosterfarrell9 @henrixapp