Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply RootPathnameMethods linting suggestion #695

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Sep 21, 2024

Linting failed due to Rails/RootPathnameMethods, this PR fixes it.

Safety: This cop is unsafe for autocorrection because Dir's children, each_child, entries, and glob methods return string element, but these methods of Pathname return Pathname element.

Apparently, require probably also works on Pathname. At least, the tests still work for me locally. I haven't checked the API for require though. This file is only used for tests anyways and as they still work I think it's not a big deal.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.45%. Comparing base (73b0fc8) to head (80b889d).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #695   +/-   ##
=======================================
  Coverage   54.45%   54.45%           
=======================================
  Files         160      160           
  Lines        6751     6751           
=======================================
  Hits         3676     3676           
  Misses       3075     3075           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit 49cf16a into dev Sep 21, 2024
5 checks passed
@Splines Splines deleted the lint/rubocop-rootpathname branch September 21, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants